Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RTI problem #70

Closed
wants to merge 6 commits into from
Closed

Implement RTI problem #70

wants to merge 6 commits into from

Conversation

tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented Jun 11, 2023

No description provided.

@tbhaxor tbhaxor mentioned this pull request Jun 11, 2023
Open
pgrete
pgrete reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@pgrete pgrete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the actual code you're running?
I don't see either of the fixes I suggested in #69

inputs/rt.in Outdated
Comment on lines 26 to 27
ix2_bc = reflecting # inner-X2 boundary flag
ox2_bc = reflecting # outer-X2 boundary flag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI reflecting boundary conditions are not working and need to be merged, see #58
Realistically, this should happen later this week or early next week.

Copy link
Contributor Author

@tbhaxor tbhaxor Jun 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to outflow for now

src/pgen/pgen.hpp Outdated Show resolved Hide resolved
src/pgen/rt.cpp Outdated
Comment on lines 93 to 94
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the deep copy that I mentioned in #69

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tbhaxor
Copy link
Contributor Author

tbhaxor commented Jun 12, 2023

@pgrete Once you have some output files

./build/bin/athenaPK -i ./inputs/rt.in  -d rt
python3 external/parthenon/scripts/python/packages/parthenon_tools/parthenon_tools/movie2d.py prim rt/*.phdf --output-directory movie

@tbhaxor
Copy link
Contributor Author

tbhaxor commented Jun 17, 2023

Hi @pgrete Did you get time to check this. I have implemented Jet problem from athena codebase. Same behaviour. No data is shown in movie.

I reconfirmed using in KH problem in AthenaPK, the movie2d.py script works.

@pgrete
Copy link
Contributor

pgrete commented Jun 19, 2023

Oh, wait, so you're using the movie2d script?
Could you please double check if you see sth in the outputs using a different viz tool (Paraview, Visit, or yt) so that we can narrow down the issue to the sim itself or the analysis.

@tbhaxor
Copy link
Contributor Author

tbhaxor commented Jun 21, 2023 •
edited
Loading

Oh, wait, so you're using the movie2d script? Could you please double check if you see sth in the outputs using a different viz tool (Paraview, Visit, or yt) so that we can narrow down the issue to the sim itself or the analysis.

Yes I checked on render view of paraview, it is empty. Actually movie2d script also works for problems like kh that are already implemented. For custom problem it is giving me undefined behaviour

@tbhaxor
Copy link
Contributor Author

tbhaxor commented Jun 25, 2023

@pgrete ping 0x00;

@tbhaxor
Copy link
Contributor Author

tbhaxor commented Jul 3, 2023

Closing this PR for now, as its idle. I will share if I found the solution

@tbhaxor tbhaxor closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgrete pgrete pgrete left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbhaxor @pgrete